DATAREDIS-661 - Refactor RedisServerCommands.getConfig(…) output to Properties. #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties. Use Properties instead of List of Strings arranged as sequence of key-value pairs to improve value lookup. Properties allows direct value lookup whereas the List previously required List scanning for an index and another index access to retrieve the actual value.
christophstrobl
pushed a commit
that referenced
this pull request
Jul 18, 2017
…roperties. Use Properties instead of List of Strings arranged as sequence of key-value pairs to improve value lookup. Properties allows direct value lookup whereas the List previously required List scanning for an index and another index access to retrieve the actual value. Original Pull Request: #255
christophstrobl
added a commit
that referenced
this pull request
Jul 18, 2017
Update JavaDoc and remove usage of MapUtils brought in via optional transitive dependency. Original Pull Request: #255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Propertiesinstead ofListof Strings arranged as sequence of key-value pairs to improve value lookup.Propertiesallows direct value lookup whereas theListpreviously requiredListscanning for an index and another index access to retrieve the actual value.Related ticket: DATAREDIS-661.